nethsm: Improve base64 handling and add key import from PEM #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the nethsm dependency to v1.1.0 and uses the new ignore_whitespace option in Base64.from_encoded to ignore whitespace in our base64 input. The main motivation is that the base64 tool per default inserts linebreaks into long data, so previously piping the base64 output into pynitrokey could lead to errors. Fixes: #538
The nethsm SDK v1.1.0 added support for importing keys from PEM files. This patch adds an import-key subcommand to pynitrokey. Fixes: #537
mmerklinger
approved these changes
May 7, 2024
daringer
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the nethsm dependency to v1.1.0 and implements two improvements that are supported by the new version: